fix(spec): support deflate for Avro manifest files - #842
Closed
jackylee-ch wants to merge 1 commit into
Closed
jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
JingsongLi
reviewed
Sep 17, 2026
JingsongLi
left a comment
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
Requirement fit: SUPPORTED. Implementation: CLEAN.
A Java-created table can persist manifest.compression=deflate, so read and write support is needed for cross-engine operation. The raw RFC 1951 decoder is scoped to the Avro OCF codec, preserves rejection of unsupported codecs, and the writer/reader codec sets remain compatible. I found no regression in the changed paths. Verification: cargo test -p paimon --lib test_deflate_manifest_compression_round_trips (passed). Review scope: OCF framing, strict decode failure, manifest-list and manifest commit/read-back.
JingsongLi
requested changes
Sep 17, 2026
JingsongLi
left a comment
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
-1 No need to do this. No use case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avro_codecrejecteddeflateand the OCF reader's codec whitelist did too, so atable whose schema carries
manifest.compression=deflatecould be neitherwritten nor read: every scan failed with
avro ocf: unsupported codec: deflate.The option comes from the persisted schema, so a table created by Java brings it
along to every paimon-rust process. Java accepts deflate through
CodecFactory.fromString.Read support is a regression:
553e4a3(#281) advertised "snappy/deflate/zstd"in its own message while shipping only three arms, replacing a reader that did
handle deflate. Write support is parity work. At HEAD the crate already reads
deflate-compressed Avro data files, so only manifests were refused.
No upstream report; found by inspection.
bzip2andxzare the same gap andstay rejected. Drive-by: the snappy mismatch message said CRC32C where the code
computes CRC-32.